Add support for additional Arexx sensors #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/devices/arexx_ml.c
Outdated
| int temp_raw = (int16_t)(sens_val << 3); // uses sign-extend | ||
| float temp_c = temp_raw / 128; | ||
| // Decode readings | ||
| float temp_c = 0.0, humidity = 0.0; |
There was a problem hiding this comment.
don't use a comma, init each var on it's own.
There was a problem hiding this comment.
Thanks, I have updated.
src/devices/arexx_ml.c
Outdated
|
|
||
| switch (msg_len) { | ||
| case 5: | ||
| if ((id & 0xF000) == 0x2000) { |
There was a problem hiding this comment.
Make this more plain, e.g. each check like if (msg_len == 5 && (id & 0xF000) == 0x2000) {
There was a problem hiding this comment.
Thanks, I have updated.
|
Thanks! Looks good, some minor code style changes needed. |
Add support for Arexx TL-3TSN, TSN-33MN and similar Arexx temperature sensors with ID's in the range 0x2000 - 0x2FFF. Example output: time : 2024-10-24 10:11:01 model : Arexx-ML ID : 2a41 Temperature: 21.12 C Sensor Raw: 0a8f Integrity : CRC
leighbb
force-pushed
the
arexx_enhancement
branch
from
9df6d61 to
7319c75
Compare
|
Very good, thanks! Let's wait some time for others to have a look, but it's ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Arexx TL-3TSN, TSN-33MN and similar Arexx temperature sensors with ID's in the range 0x2000 - 0x2FFF.
Example output:
time : 2024-10-24 10:11:01
model : Arexx-ML ID : 2a41
Temperature: 21.12 C Sensor Raw: 0a8f Integrity : CRC